Update PTO pseudocode to better match text #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are bytes_in_flight, then always do a standard PTO. If not, it must be a client which is unsure if the peer has completed address validation. Fixes #3070
ianswett
added
editorial
ianswett
changed the title
ianswett
changed the title
martinthomson
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Oh, I see how this all fits together now. I think that it's entirely too clever.
I suspect that some commentary is going to be needed to explain that the PTO timer isn't armed when
a: the server hits address validation limits (the new text), and
b: the endpoint has nothing to send (except when the client isn't sure that the server has completed validation)
|
@martinthomson I added two comments to address the two points of potential confusion you raised in your last comment, PTAL. |
martinthomson
approved these changes
Mar 15, 2020
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
martinthomson
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are bytes_in_flight, then always do a standard PTO.
If not, it must be a client which is unsure if the peer has completed address validation.
Fixes #3070