-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PTO pseudocode to better match text #3461
Conversation
If there are bytes_in_flight, then always do a standard PTO. If not, it must be a client which is unsure if the peer has completed address validation. Fixes #3070
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see how this all fits together now. I think that it's entirely too clever.
I suspect that some commentary is going to be needed to explain that the PTO timer isn't armed when
a: the server hits address validation limits (the new text), and
b: the endpoint has nothing to send (except when the client isn't sure that the server has completed validation)
@martinthomson I added two comments to address the two points of potential confusion you raised in your last comment, PTAL. |
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
If there are bytes_in_flight, then always do a standard PTO.
If not, it must be a client which is unsure if the peer has completed address validation.
Fixes #3070